This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
Update tx.rs to include return_code in server respone #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rllola
reviewed
Feb 17, 2024
src/server/tx.rs
Outdated
| @@ -189,9 +182,10 @@ impl TryFrom<Row> for TxInfo { | |||
| let gas_limit_multiplier = row.try_get("gas_limit_multiplier")?; | |||
| let code: Option<Vec<u8>> = row.try_get("code")?; | |||
| let data: Option<Vec<u8>> = row.try_get("data")?; | |||
| let return_code = row.try_get("return_code").ok(); // Parsing return_code | |||
There was a problem hiding this comment.
Maybe we could use row.try_get("return_code")?; to keep it align with the rest.
There was a problem hiding this comment.
If you can do the change I think we will be good to merge.
msobh13
commented
Feb 17, 2024
changed to row.try_get("return_code")?;
msobh13
commented
Feb 17, 2024
HadesGuard
pushed a commit
to HadesGuard/namadexer
that referenced
this pull request
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.