This repository has been archived by the owner on Jun 19, 2024. It is now read-only.
feat: data stored as json #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rllola
force-pushed
the
feat/json-sql
branch
from
8c13c7f to
ffda60c
Compare
neithanmo
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
It looks good to me, this reduces database layout complexity, and there is no need for more tables for each transaction type. as you said, we would need to benchmark this, and it will depend on query complexity, for example, one that returns a list of all transfer transactions linked to a specific target, source or key. this will for sure take more time to process whereas having a tx_transfer table would be faster?, again this would depend on query complexity which would need to process that JSON.
rllola
force-pushed
the
feat/json-sql
branch
from
ffda60c to
9abc1d8
Compare
neithanmo
approved these changes
Feb 22, 2024
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the data in JSON would allow to store all the transaction data in one table making indexing faster but looking for data maybe a little bit slower. It also has the advantage of removing a lot of code.
This need to be tested before merged.