Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/fix convert description parser rebase #62

Closed

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Sep 10, 2024

Made miscellaneous adjustments in order to get namadac to work better with the hardware wallet. Specifically the following changes were made:

  • Allow the creation of more convert randomness than there are convert descriptions. This might simplify the implementation of namadac where randomness is obtained separately prior to Transaction construction
  • Fix the parser so that it parses the generators of convert description information objects. This issue was preventing the parsing of MASP Transaction builders.
  • Now check whether the TxId digest computation throws any errors and propagates them. A safety measure to prevent computations from continuing with the wrong TxId digest.
  • Fix the hashing of spend descriptions so that the anchor comes from the Sapling bundle. Note that its presence is guaranteed whenever there's at least one spend description.
  • Weakened the conditions under which the Sapling bundle is hashed to just be whenever a spend, convert, or output description is present. This fixes the handling of Transactions with zero output descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants