Get rid of a bunch of TODOs in error messages

src/Canonicalize/Effects.hs

@@ -73,7 +73,7 @@ figureOutKind region name rootType =
             <* checkPortType (makeError region name) incomingType
 
     _ ->
-      Result.throw region (error "TODO - bad overall type")
+      Result.throw region (Error.BadPort name rootType)
 
 
 makeError :: R.Region -> String -> T.Canonical -> Maybe String -> A.Located Error.Error

src/Reporting/Error/Canonicalize.hs

@@ -23,6 +23,7 @@ data Error
     | Export String [String]
     | DuplicateExport String
     | Port PortError
+    | BadPort String Type.Canonical
 
 
 
@@ -242,6 +243,21 @@ toReport localizer err =
               ]
           )
 
+    BadPort name tipe ->
+      Report.report
+        "PORT ERROR"
+        Nothing
+        ("Port `" ++ name ++ "` has an invalid type."
+        )
+        ( Help.stack
+            [ text ("You are saying it should be:")
+            , indent 4 (RenderType.toDoc localizer tipe)
+            , Help.reflowParagraph $
+                "But you need to use the particular format described here:\
+                \ <http://guide.elm-lang.org/effect_managers/>"
+            ]
+        )
+
 
 argMismatchReport :: String -> Var.Canonical -> Int -> Int -> Report.Report
 argMismatchReport kind var expected actual =
@@ -288,6 +304,9 @@ extractSuggestions err =
     Port _ ->
         Nothing
 
+    BadPort _ _ ->
+        Nothing
+
 
 unsafePromote :: Type.Raw -> Type.Canonical
 unsafePromote (A.A _ rawType) =

src/Reporting/Error/Syntax.hs

@@ -135,7 +135,7 @@ toReport _localizer err =
               "If you just wanted a normal module, change the keywords `effect module`\
               \ to `module` and you should be all set. If you want a proper effect module,\
               \ you need to specify your commands and/or subscriptions. Read more about this\
-              \ here: <TODO> (please forgive me if I forgot to fill this in!)"
+              \ here: <http://guide.elm-lang.org/effect_managers/>"
           )
 
     MissingManagerOnEffectModule name ->
@@ -147,7 +147,7 @@ toReport _localizer err =
               "There is a small set of top-level functions and values that must be defined\
               \ in any complete effect module. The best thing is probably to just read more\
               \ about effect modules here:\
-              \ <TODO> (please forgive me if I forgot to fill this in!)"
+              \ <http://guide.elm-lang.org/effect_managers/>"
           )
 
     UnexpectedPort name ->

src/Reporting/Error/Type.hs

@@ -458,7 +458,8 @@ mismatchToReport localizer (MismatchInfo hint leftType rightType maybeReason) =
           ( cmpHint
               ("Your `" ++ name ++ "` function has this type:")
               "But it needs to have a type like this:"
-              [ "TODO - link to overview of effect managers"
+              [ "You can read more about setting up effect managers properly here:\
+                \ <http://guide.elm-lang.org/effect_managers/>"
               ]
           )
 
@@ -471,8 +472,8 @@ mismatchToReport localizer (MismatchInfo hint leftType rightType maybeReason) =
           ( cmpHint
               "The state created by `init` has this type:"
               ("But `" ++ name ++ "` expects state of this type:")
-              [ "Make the two state types match and you should be all set!"
-              , "TODO - link to overview of effect managers"
+              [ "Make the two state types match and you should be all set! More info here:\
+                \ <http://guide.elm-lang.org/effect_managers/>"
               ]
           )
 
@@ -483,8 +484,8 @@ mismatchToReport localizer (MismatchInfo hint leftType rightType maybeReason) =
           ( cmpHint
               "The `onEffects` function can send this type of message:"
               "But the `onSelfMsg` function receives this type:"
-              [ "Make the two message types match and you should be all set!"
-              , "TODO - link to overview of effect managers"
+              [ "Make the two message types match and you should be all set! More info here:\
+                \ <http://guide.elm-lang.org/effect_managers/>"
               ]
           )