generated from runelite/example-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helper Maker #1872
Open
Zoinkwiz
wants to merge
18
commits into
master
Choose a base branch
from
helper-maker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Helper Maker #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This default logic to be that conditions attached to a step are the things which all need to pass to move on to the next step. This may be flawed for many use-cases.
Zoinkwiz
force-pushed
the
helper-maker
branch
from
November 25, 2024 23:48
25bb097
to
cdf8e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to allow for players to make very simple helpers which they can share with one another, such as small guides.
It works off allowing JSON to be made, which can be interpreted as a QuestHelper via JsonToQuest as a JsonQuestHelper.
Expected fields and constants are defined in JsonConstants, StepParameterDefinitions, and RequirementParameterDefinitions.
A UI exists to make the creation process easier than editing flat JSON.
The general structure of this is:
Each step of the ConditionalStep is then a section in the sidebar, with the locking capabilities enabled by default due to the assumption any of these steps may be buggy.
Notes: