Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helper Maker #1872

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add Helper Maker #1872

wants to merge 18 commits into from

Conversation

Zoinkwiz
Copy link
Owner

@Zoinkwiz Zoinkwiz commented Nov 25, 2024

This is intended to allow for players to make very simple helpers which they can share with one another, such as small guides.

It works off allowing JSON to be made, which can be interpreted as a QuestHelper via JsonToQuest as a JsonQuestHelper.

Expected fields and constants are defined in JsonConstants, StepParameterDefinitions, and RequirementParameterDefinitions.

A UI exists to make the creation process easier than editing flat JSON.

Screenshot 2024-11-25 233711

The general structure of this is:

  • A list of Requirements
  • A list of Steps, which can make use of requirements for their panels (usual green/red)
  • A list of actual Steps (QuestSteps, needs a name change), which are effectively just instances of each Step as a Requirement/Step combination in a ConditionalStep.

Each step of the ConditionalStep is then a section in the sidebar, with the locking capabilities enabled by default due to the assumption any of these steps may be buggy.

Notes:

  • Very ugly, needs UI work
  • We're importing data. It should be safe, but worth considering any potential security issues that could arise
  • No concept of saving a helper, you'd need to keep the JSON handy and import each session
  • Can this be abused to allow for highlighting things against the Third Party Guidelines?
  • We should get some proper tests going for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant