Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIL-5446: PDT add listen #249

Merged
merged 5 commits into from
Oct 26, 2023
Merged

ZIL-5446: PDT add listen #249

merged 5 commits into from
Oct 26, 2023

Conversation

WuBruno
Copy link
Contributor

@WuBruno WuBruno commented Oct 26, 2023

No description provided.

@WuBruno WuBruno changed the title Pdt add listen ZIL-5446: PDT add listen Oct 26, 2023
@WuBruno WuBruno marked this pull request as draft October 26, 2023 13:10
WuBruno
WuBruno commented Oct 26, 2023
View reviewed changes
products/pdt/pdtlisten/src/lib.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/lib.rs Show resolved Hide resolved
@WuBruno WuBruno marked this pull request as ready for review October 26, 2023 14:24
JamesHinshelwood
JamesHinshelwood approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me and seems like it would do the job 👍 There are some comments which might be worth discussing though.

products/pdt/pdtlisten/src/lib.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
products/pdt/pdtlisten/src/listener.rs Show resolved Hide resolved
@WuBruno WuBruno merged commit 3ce0b52 into main Oct 26, 2023
6 checks passed
@WuBruno WuBruno deleted the pdt-add-listen branch October 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troelsfr troelsfr Awaiting requested review from troelsfr

@rrw-zilliqa rrw-zilliqa Awaiting requested review from rrw-zilliqa rrw-zilliqa is a code owner

@JamesHinshelwood JamesHinshelwood Awaiting requested review from JamesHinshelwood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WuBruno @JamesHinshelwood