Skimming through English documentation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current status looks quite good. There were some typos and minor mistakes that I attempted to fix. Probably the biggest 'disagreement' is about the use of hyphen. I removed a whole bunch of them since they looked unfamiliar in certain places (e,g,. 'Source-directory' looks strange to me as opposed to 'Source directory'). All in all, I don't really have a strong opinion about any of the changes I made and I would not be offended if you were to ignore the whole PR.
|
The hyphen is the last remnant of me originally speaking German, I guess hehehe Thanks for the corrections! |
|
I kind of guessed it. It is similar in Norwegian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation look very good as it is. There were some typos and minor mistakes that I attempted to fix. Probably the biggest 'disagreement' is about the use of hyphen. I removed a whole bunch of them since they looked unfamiliar in certain places (e,g,. 'Source-directory' looks strange to me as opposed to 'Source directory'). All in all, I don't really have a strong opinion about any of the changes I made and I would not be offended if you were to ignore the whole PR.