Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RETURN_SCENARIO env variables #671

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

thesethtruth
Copy link
Collaborator

Datamodel scenario feedback in any environment

A feature to help debug AnyLogic model results. This setting is used in the /wt/api/nextjs/v2/holon/ endpoint to determine whether to send back the used scenario (through the serializer) or not. This should ideally not be set to true in production since it will impact performance.

RETURN_SCENARIO=True

One thing I'm unsure of is whether setting the Azure settings to this setting will be able to toggle this functionality without having to push a new container. If yes, then we can use this setting to develop with the content on main and later disable the functionality when we are happy with the outcomes.

@thesethtruth thesethtruth requested a review from Erikvv April 26, 2023 12:55
@thesethtruth thesethtruth changed the title add RETURN_SCENARIO env variables add RETURN_SCENARIO env variables Apr 26, 2023
@Erikvv
Copy link
Member

Erikvv commented Apr 26, 2023

This should ideally not be set to true in production since it will impact performance.

Doel je hier op de grootte van de response of triggert de serializer database queries? Want de response is ~175kb uncompressed dus dit valt wel mee.

If yes, then we can use this setting to develop with the content on main and later disable the functionality when we are happy with the outcomes.

Idee: dit met een cookie te zetten ipv enviroment variable. Dan kan een modelleur die cookie setten als hij het wilt zien.

@thesethtruth thesethtruth merged commit 9d3e419 into main Apr 26, 2023
@thesethtruth thesethtruth deleted the scenario-feeback-on-env branch April 26, 2023 14:17
@thesethtruth thesethtruth mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants