Implement support for NeoForge #13
Conversation
This uses Forge's built-in fml.forgeGroup flag to distinguish Forge and NeoForge's package names. Consequently, this flag's value needs to be passed to most installer-related functions.
|
Now that I've come across concrete proof of it, I should also acknowledge that NeoForge's version of FML doesn't actually use the |
I was hoping not to hardcode any package names here, but this is the only way to unbreak manual installs without unintuitively asking users to add the flag themselves.
|
I'd say the PR is feature-complete now, so I'm un-marking it as a draft. That said, there is still one lingering issue I haven't been able to figure out during development, but I'm not sure if it's related to the PR or not; when launching an installed NeoForge instance, NeoForge crashes because it can't find its built-in language providers. From what I've investigated regarding the issue, for whatever reason the language provider classes don't end up in FancyModLoader's class loader despite being on the classpath. Classic Forge works as expected, however. I'll update the PR with a fix if I can find one out, but I've had no luck over the last two days. Edit: This (hopefully) might be just a NeoForge bug; see neoforged/NeoForge#68. |
|
In response to your crashes, I'll look into it this weekend and discuss it when I have a definitive solution. |
|
No need! As of NeoForge version 47.1.60 (where the bug I mentioned was fixed), NeoForge works as expected when installed using this PR! |
|
Can a release be created to push out these changes? |
|
@Pyker released |
|
Thanks! |
|
I confirm, it works just fine! |
This PR allows for ForgeWrapper to launch NeoForge just as it launches Minecraft Forge. This is mainly accomplished using Forge's
fml.forgeGrouplaunch argument, which specifies the base path of Forge-related packages; for Minecraft Forge, this has always beennet.minecraftforge, whereas NeoForge could usenet.neoforged. With this PR, ForgeWrapper now stores the value of this flag and uses it when determining the path to the Forge installer.Additionally, this PR fixes a bug preventing ForgeWrapper from compiling on Java versions newer than Java 8, which I found useful developing using Java 17.
Resolves #12.