chore(deps): update dependency webob to v1.8.8 [security] #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==1.8.7
->==1.8.8
GitHub Vulnerability Alerts
CVE-2024-42353
Impact
When WebOb normalizes the HTTP Location header to include the request hostname, it does so by parsing the URL that the user is to be redirected to with Python's urlparse, and joining it to the base URL.
urlparse
however treats a//
at the start of a string as a URI without a scheme, and then treats the next part as the hostname.urljoin
will then use that hostname from the second part as the hostname replacing the original one from the request.WebOb uses
urljoin
to take the request URI and joining the redirect location, so assuming the request URI is:https://example.org//example.com/some/path
, and the URL to redirect to (for example by adding a slash automatically) is//example.com/some/path/
that gets turned byurljoin
into:Which redirects from
example.org
where we want the user to stay toattacker.com
Patches
This issue is patched in WebOb 1.8.8
Older versions of WebOb continue to be vulnerable to this issue, and should be avoided.
Workarounds
Any use of the
Response
class that includes alocation
can be rewritten to make sure to always pass a full URI that includes the hostname to redirect the user to.Thanks
This issue was reported via the Pylons Project Security List
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.