Add --export-texts option #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaf-mandel
force-pushed
the
feature/text-exports
branch
from
e2d2a93 to
8bc5cfc
Compare
|
Thank you @olaf-mandel for the multiple PRs you submitted, I'll make sure to have a look at all of them. I think this is a great addition and all looks good just a few minor notes |
Zehina
reviewed
Dec 17, 2023
Zehina
requested changes
Dec 17, 2023
Add a new option --export-texts that extracts several texts from the various webpages and stores them as text-files: * `summary.txt` contains the series summary from the series list page * `*_title.txt` contains the title of each chapter * `*_notes.txt` contains the author notes of each chapter, if present
olaf-mandel
force-pushed
the
feature/text-exports
branch
from
8bc5cfc to
cd784ee
Compare
Zehina
approved these changes
Dec 18, 2023
Add an option that modifies how --export-texts behaves: either write the texts to individual plain text files or to a single JSON file or write both. Notes: * this changes the default behaviour from text to JSON * the `<chapter>_notes.txt` file is now only created if there are actually any notes present
olaf-mandel
force-pushed
the
feature/text-exports
branch
from
cd784ee to
cc5f406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option --export-texts that extracts several texts from the various webpages and stores them as text-files:
summary.txtcontains the series summary from the series list page*_title.txtcontains the title of each chapter*_notes.txtcontains the author notes of each chapter, if presentIf --export-texts is used together with --separate, then this changes the names of the chapter-directores: they now have a suffix based on the title.Add --export-format option
Add an option that modifies how --export-texts behaves: either write the texts to individual plain text files or to a single JSON file or write both.