Use pathlib for clang_tidy_binary and args list for version

This fixes getting the version on windows because the forward slashes are not properly interpreted in `subprocess.run` in shell mode.

post/clang_tidy_review/clang_tidy_review/__init__.py

@@ -59,7 +59,12 @@ class PRReview(TypedDict):
 
 
 def build_clang_tidy_warnings(
-    line_filter, build_dir, clang_tidy_checks, clang_tidy_binary, config_file, files
+    line_filter,
+    build_dir,
+    clang_tidy_checks,
+    clang_tidy_binary: pathlib.Path,
+    config_file,
+    files,
 ) -> None:
     """Run clang-tidy on the given files and save output into FIXES_FILE"""
 
@@ -88,12 +93,11 @@ def build_clang_tidy_warnings(
     print(f"Took: {end - start}")
 
 
-def clang_tidy_version(clang_tidy_binary: str):
+def clang_tidy_version(clang_tidy_binary: pathlib.Path):
     try:
         version_out = subprocess.run(
-            f"{clang_tidy_binary} --version",
+            [clang_tidy_binary, "--version"],
             capture_output=True,
-            shell=True,
             check=True,
             text=True,
         ).stdout
@@ -111,7 +115,7 @@ def clang_tidy_version(clang_tidy_binary: str):
 
 
 def config_file_or_checks(
-    clang_tidy_binary: str, clang_tidy_checks: str, config_file: str
+    clang_tidy_binary: pathlib.Path, clang_tidy_checks: str, config_file: str
 ):
     version = clang_tidy_version(clang_tidy_binary)
 
@@ -739,7 +743,7 @@ def create_review(
     pull_request: PullRequest,
     build_dir: str,
     clang_tidy_checks: str,
-    clang_tidy_binary: str,
+    clang_tidy_binary: pathlib.Path,
     config_file: str,
     include: List[str],
     exclude: List[str],

post/clang_tidy_review/clang_tidy_review/review.py

@@ -7,6 +7,7 @@
 
 import argparse
 import os
+import pathlib
 import re
 import subprocess
 
@@ -34,7 +35,7 @@ def main():
     parser.add_argument("--repo", help="Repo name in form 'owner/repo'")
     parser.add_argument("--pr", help="PR number", type=int)
     parser.add_argument(
-        "--clang_tidy_binary", help="clang-tidy binary", default="clang-tidy-14"
+        "--clang_tidy_binary", help="clang-tidy binary", default="clang-tidy-14", type=pathlib.Path
     )
     parser.add_argument(
         "--build_dir", help="Directory with compile_commands.json", default="."