Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the version of package format #120

Merged
merged 1 commit into from
Apr 22, 2019

Conversation

708yamaguchi
Copy link
Contributor

In our Fetch robot PC (indigo), we cannot build fetch_calibration with fetch_ros of version 0.7.15.
This is because <package format="3"> is not compatible with python-catkin-pkg of 0.3.9.
0.3.9 is the newest python-catkin-pkg version which our Fetch robot can install.

$ dpkg -l python-catkin-pkg
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                          Version                     Architecture                Description
+++-=============================================-===========================-===========================-===============================================================================================
ii  python-catkin-pkg                             0.3.9-100                   all                         catkin package library

In this PR, we change the version of <package format> in package.xml in fetch_ros (version 3 -> 2).

CC. @sktometometo

@erelson erelson requested a review from moriarty April 12, 2019 15:48
@knorth55
Copy link
Contributor

@moriarty What is status of this PR? We cannot build indigo-devel with indigo fetch. We seriously want this fix to be merged.

@erelson
Copy link
Collaborator

erelson commented Apr 22, 2019

@knorth55 Note that you can manually revert this change and the code should build.

@knorth55
Copy link
Contributor

I know but we want to keep code with deb package.
we are waiting for debian release.

@moriarty
Copy link
Contributor

Oh sorry this is the first i’m seeing this PR.

So the problem is packages.fetchrobotics.com our mirror of the ROS packages hasn’t been updated...

It hasn’t been outdated on purpose- to ensure it’s stable...

The reason I was using package v3 is to move towards ROS2, and also move towards single master branches so that we could continue to support older versions with less effort... many of the very stable ROS packages are able to accomplish this...

But for now I think the fix will be to revert the change to package format 3 from indigo.

@moriarty moriarty merged commit 3653ab5 into ZebraDevs:indigo-devel Apr 22, 2019
@moriarty
Copy link
Contributor

FYI: @cjds

@moriarty
Copy link
Contributor

@knorth55 @erelson @cjds @rctoris

I've been testing my changes to indigo using Docker, and hadn't had a problem with this.
Also, the build farm was passing it's build.
In that image, we have python-catkin-pkg 0.4.10

The Docker image isn't on dockerhub, but the dockerfile is here:
ZebraDevs/fetch_gazebo#46

amoriarty@amoriarty-XPS-8930:~$ docker run -it fetch-gazebo:ros-indigo-nvidia-fetch
root@e6e559e5989c:/# dpkg -l python-catkin-pkg
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                Version        Architecture   Description
+++-===================-==============-==============-===========================================
ii  python-catkin-pkg   0.4.10-100     all            catkin package library
root@e6e559e5989c:/# exit

I've tagged @cjds to see if we can release a binary version of our drivers into Indigo, before they turn off the Indigo Build Farm... when Indigo and Ubuntu 14.04 become EOL... This would put a binary version of our drivers onto the ros archive, because we're not planning to keep the indigo mirror around for ever (although I don't know when it will be turned off)

I don't know if we'll have enough time to get our drivers into the archive at this point.

@knorth55 & @708yamaguchi @sktometometo do you have any plans to upgrade to melodic?

@knorth55
Copy link
Contributor

knorth55 commented Apr 22, 2019

We have plan to upgrade our fetch to melodic, but not now because our software is not supported for melodic.
We still want to use indigo, so, for this package, we can install it from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants