-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower the version of package format #120
Conversation
@moriarty What is status of this PR? We cannot build |
@knorth55 Note that you can manually revert this change and the code should build. |
I know but we want to keep code with |
Oh sorry this is the first i’m seeing this PR. So the problem is packages.fetchrobotics.com our mirror of the ROS packages hasn’t been updated... It hasn’t been outdated on purpose- to ensure it’s stable... The reason I was using package v3 is to move towards ROS2, and also move towards single master branches so that we could continue to support older versions with less effort... many of the very stable ROS packages are able to accomplish this... But for now I think the fix will be to revert the change to package format 3 from indigo. |
FYI: @cjds |
@knorth55 @erelson @cjds @rctoris I've been testing my changes to indigo using Docker, and hadn't had a problem with this. The Docker image isn't on dockerhub, but the dockerfile is here:
I've tagged @cjds to see if we can release a binary version of our drivers into Indigo, before they turn off the Indigo Build Farm... when Indigo and Ubuntu 14.04 become EOL... This would put a binary version of our drivers onto the ros archive, because we're not planning to keep the indigo mirror around for ever (although I don't know when it will be turned off) I don't know if we'll have enough time to get our drivers into the archive at this point. @knorth55 & @708yamaguchi @sktometometo do you have any plans to upgrade to melodic? |
We have plan to upgrade our fetch to melodic, but not now because our software is not supported for melodic. |
In our Fetch robot PC (indigo), we cannot build
fetch_calibration
withfetch_ros
of version0.7.15
.This is because
<package format="3">
is not compatible withpython-catkin-pkg
of0.3.9
.0.3.9
is the newestpython-catkin-pkg
version which our Fetch robot can install.In this PR, we change the version of
<package format>
inpackage.xml
infetch_ros
(version 3 -> 2).CC. @sktometometo