Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Minor cleanups #9198

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: Minor cleanups #9198

wants to merge 6 commits into from
+15 −7

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 3, 2025

Motivation

Resolve #9139 (comment) and #9139 (comment) and a few other nits.

Tests

N/A

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

@upbqdn upbqdn added A-docs Area: Documentation C-testing Category: These are tests P-Critical 🚑 labels Feb 3, 2025
@upbqdn upbqdn self-assigned this Feb 3, 2025
@upbqdn upbqdn requested review from a team as code owners February 3, 2025 20:58
@upbqdn upbqdn requested review from arya2 and removed request for a team February 3, 2025 20:58
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 3, 2025
oxarbitrage
oxarbitrage previously approved these changes Feb 3, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@arya2 arya2 arya2 approved these changes

Assignees

@upbqdn upbqdn

Labels
A-docs Area: Documentation C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Critical 🚑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upbqdn @arya2 @oxarbitrage