Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Updates ignored failure messages in lightwalletd_integration test #8784

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Aug 20, 2024

Motivation

The error returned by the getblockchaininfo RPC method was updated in #8769 for consistency, but now the lightwalletd_integration test frequently fails because the expected failure message isn't ignored.

Solution

  • Updates the ignored failure message.

Related changes:

  • Updates an error conversion to use the .ok_or_server_error() method

Tests

The lightwalletd_integration test should pass for this PR. (https://github.com/ZcashFoundation/zebra/actions/runs/10478114195/job/29021273807?pr=8784)

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd P-Low ❄️ labels Aug 20, 2024
@arya2 arya2 self-assigned this Aug 20, 2024
@arya2 arya2 requested a review from a team as a code owner August 20, 2024 19:39
@arya2 arya2 requested review from oxarbitrage and removed request for a team August 20, 2024 19:39
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Aug 20, 2024
@oxarbitrage
Copy link
Contributor

Can you post links to the failures ? Thanks!

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify mergify bot merged commit 9fbcb4c into main Aug 20, 2024
134 of 135 checks passed
@mergify mergify bot deleted the update-ignored-lwd-failure-msg branch August 20, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-cleanup Category: This is a cleanup C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG lightwalletd any work associated with lightwalletd P-Low ❄️
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants