Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(network): Updates minimum protocol version for NU6 on Testnet and Mainnet #8733

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Aug 1, 2024

Motivation

Zebra should expect its peers to use the NU6 protocol version once NU6 is active.

The relevant ZIP is still in draft status, and the network protocol versions for Testnet and Mainnet may still change.

Part of #8689.

Specifications & References

zcash/zips#878

Solution

  • Updates the minimum protocol version for NU6 on Mainnet and Testnet

Related changes:

  • Fixes the minimum protocol version for Sapling on custom Testnets and Regtest

Tests

Updates the relevant vectors test.

Follow-up Work

We likely want to update the CURRENT_NETWORK_PROTOCOL_VERSION again before releasing a version of Zebra to deploy NU6 on Mainnet.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 self-assigned this Aug 1, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Aug 1, 2024
@arya2 arya2 added S-blocked Status: Blocked on other tasks NU-6 Network Upgrade: NU6 specific tasks labels Aug 1, 2024
@mpguerra mpguerra linked an issue Aug 9, 2024 that may be closed by this pull request
@arya2 arya2 marked this pull request as ready for review August 20, 2024 15:54
@arya2 arya2 requested a review from a team as a code owner August 20, 2024 15:54
@arya2 arya2 removed the request for review from a team August 20, 2024 15:54
@arya2 arya2 requested a review from upbqdn August 20, 2024 15:54
@arya2 arya2 force-pushed the nu6-protocol-version branch from 907215f to 272be68 Compare August 20, 2024 15:54
@arya2 arya2 added P-High 🔥 and removed S-blocked Status: Blocked on other tasks labels Aug 20, 2024
@arya2 arya2 requested a review from oxarbitrage August 20, 2024 15:55
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mergify bot added a commit that referenced this pull request Aug 20, 2024
@mergify mergify bot merged commit 0ecc5eb into main Aug 20, 2024
133 of 135 checks passed
@mergify mergify bot deleted the nu6-protocol-version branch August 20, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG NU-6 Network Upgrade: NU6 specific tasks P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set the NU6 testnet activation height and network protocol version
2 participants