Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(CI): Unpin cargo-deny-action #8197

Merged
merged 1 commit into from
Jan 25, 2024
Merged

change(CI): Unpin cargo-deny-action #8197

merged 1 commit into from
Jan 25, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jan 25, 2024 •
edited
Loading

Motivation

Close #8193.

PR Author Checklist

  • Will the PR name make sense to users?
  • Does the PR have a priority label?

Testing

The new version of the action contains a fix for the original issue, so let's see if it doesn't panic in CI.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️ labels Jan 25, 2024
@upbqdn upbqdn self-assigned this Jan 25, 2024
@upbqdn upbqdn requested a review from a team as a code owner January 25, 2024 12:20
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team January 25, 2024 12:20
@upbqdn upbqdn changed the title Unpin cargo deny in CI change(CI): Unpin cargo deny in CI Jan 25, 2024
@upbqdn upbqdn changed the title change(CI): Unpin cargo deny in CI change(CI): Unpin cargo deny Jan 25, 2024
@upbqdn upbqdn changed the title change(CI): Unpin cargo deny change(CI): Unpin cargo deny Jan 25, 2024
@upbqdn upbqdn changed the title change(CI): Unpin cargo deny change(CI): Unpin cargo-deny-action Jan 25, 2024
@upbqdn upbqdn changed the title change(CI): Unpin cargo-deny-action change(CI): Unpin cargo-deny-action Jan 25, 2024
oxarbitrage
oxarbitrage approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that works, thanks!

@mergify mergify bot merged commit c08ad45 into main Jan 25, 2024
95 checks passed
@mergify mergify bot deleted the unpin-cargo-deny-action branch January 25, 2024 16:17
@upbqdn upbqdn mentioned this pull request Feb 23, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Low ❄️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin cargo-deny-action
2 participants
@upbqdn @oxarbitrage