-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(rpc): Implement the z_getsubtreesbyindex
RPC
#7436
Conversation
Temporary network error on a draft PR, doesn't need fixing or even restarting:
|
Revert "Temporarily remove the z_get_subtrees_by_index RPC method" This reverts commit 30d049e.
e9c31f1
to
8a16a4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Revert "Temporarily remove the z_get_subtrees_by_index RPC method" This reverts commit 30d049e.
Motivation
This PR implements the
z_getsubtreesbyindex
RPC method and return type.It needs data from PR #7350 for testing, but it can merge without that PR and we can write tests later.
Close #6954.
Specifications
See https://github.com/zcash/zcash/pull/6677/files#diff-decae4be02fb8a47ab4557fe74a9cb853bdfa3ec0fa1b515c0a1e5de91f4ad0bR1458-R1475
The specs for this RPC aren't on the RPC spec site yet.
Complex Code or Requirements
This RPC must return the same data and format as
zcashd
.The data for this RPC must be added to the database from the non-finalized tip backwards (or all at the same time), see ticket #7407 for details.
Solution
Implement the RPC method, arguments, and return type
pool
argumentzcashd
's behaviour of returning an empty list if thestart_index
is not availablestart_index + limit
would overflow, matchingzcashd
's behaviourTesting
We'll split tests into separate tickets, as requested here:
#6954 (comment)
New RPC methods will need:
zcash-rpc-diff
test results in a comment on the PR, to make sure we matchzcashd
And possibly:
Review
This PR is ready for review, we will write tests in other tickets.
Reviewer Checklist