-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(rpc): note tree sizes to getblock
api
#7278
Conversation
@Mergifyio update |
☑️ Nothing to do
|
@Mergifyio update |
✅ Branch has been successfully updated |
I am still not sure what is going on with the CI here as it seems that it still using the old lightwalletd cache. I tried running the test of this PR locally and i was able to see the debug log i added here and the test pass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you!
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio refresh |
✅ Pull request refreshed |
Motivation
We need to add sapling and orchard tree sizes to
getblock
method.Close #6952
Solution
We have state methods to get what we need from a block.
This PR is a draft until it passed newly added CI tests.
Review
Reviewer Checklist
Follow Up Work