fix(commands): Require an argument name before the list of tracing filters when used without a subcommand

[arya2]

Motivation

Supplying an incorrect subcommand name should not run start.

This PR does not affect how tracing filters are parsed where the user provided the start subcommand.

Closes #7052

Solution

• Adds long to filters field on EntryPoint (this field is ignored by the tracing component)
• Appends start to the end when no subcommand is provided (instead of before the first filter)
• Appends filters arg after the default subcommand

Related: I tried EnvFilter::try_new().expect(), but the format was too permissive, (this was noted in the issue as well.)

Review

Anyone can review.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

[teor2345]

This looks like a breaking change, does it need to wait for the 1.1.0 release?

(I don't mind either way, just checking as the person tagging the release.)

[codecov]

Codecov Report

Merging #7056 (9df05f8) into main (5859fac) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7056      +/-   ##
==========================================
+ Coverage   77.24%   77.41%   +0.16%     
==========================================
  Files         310      310              
  Lines       41833    41830       -3     
==========================================
+ Hits        32315    32382      +67     
+ Misses       9518     9448      -70     

[arya2]

This looks like a breaking change, does it need to wait for the 1.1.0 release?

I'd be okay with a patch update since it's a very small breaking change.

[teor2345]

This looks like a breaking change, does it need to wait for the 1.1.0 release?

I'd be okay with it okay in a patch update since it's a very small breaking change.

Seems ok, just as long as it has something in the changelog.

[teor2345]

Looks good, some optional suggestions about the changelog and testing.

[teor2345]

Thanks for this fix!