fix(log): Limit RPC failure log length, add details to RPC failure logs #6754
+25
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra will log all the data sent by an RPC on failure, including up to 2MB of block or transaction data.
I also improved some specific RPC failure and RPC test logs as part of this PR.
Solution
Related fixes:
Review
This is a low priority usability fix, it also reduces log size on disk.
Reviewer Checklist