-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some additional checks to the acceptance mempool test #2880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea for a test.
But I'd like to create a new test, rather than re-using the existing one.
A new test could sync more blocks, and get better test coverage.
I also made some suggestions for making the test more reliable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just committed a minor fix, we should be good to merge now
I'm auto-merging this PR, so upcoming PRs are better tested. Thanks! |
Motivation
We want to check some additional stuff to the mempool acceptance test we added at #2862
Close #2691
Solution
Add missing checks.
Review
The code added here is short, so anyone can review.
Reviewer Checklist