Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some additional checks to the acceptance mempool test #2880

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to check some additional stuff to the mempool acceptance test we added at #2862

Close #2691

Solution

Add missing checks.

Review

The code added here is short, so anyone can review.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea for a test.

But I'd like to create a new test, rather than re-using the existing one.
A new test could sync more blocks, and get better test coverage.

I also made some suggestions for making the test more reliable.

zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just committed a minor fix, we should be good to merge now

@teor2345 teor2345 enabled auto-merge (squash) October 15, 2021 01:27
@teor2345
Copy link
Contributor

I'm auto-merging this PR, so upcoming PRs are better tested.

Thanks!

@teor2345 teor2345 merged commit d88e44f into ZcashFoundation:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zebrad acceptance tests for the mempool
2 participants