Stop panicking when pruning unused queued blocks #2842
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When Zebra prunes queued blocks, it drops their senders without sending a response. This caused a panic in one Zebra testnet node, shortly after NU5 activation.
When Zebra prunes queued blocks, it doesn't remove their known UTXOs.
This is unexpected work in Sprint 20.
Logs
The panic happens when the
CommitBlock
future checks for a response on its oneshot receiver.Solution
Review
Anyone can review this PR.
Reviewer Checklist