Improve MockService ergonomics for sending error responses
#2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic `Error` type parameter doesn't have to implement the standard `Error` trait, so having that constraint only unnecessarily limits the types that can be used as an error for the service.
Make the usage a little more ergonomic by not having to write manual error type conversions.
Show an example that responds to a call to the service with an error.
teor2345
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on the tests in #2801, I stumbled onto an issue with the
MockService. Unfortunately, theErrorgeneric type parameter had a constraint where it needed tostd::error::Error, and that's not actually necessary. This caused some issues when I was trying to respond to requests with errors.Solution
I removed the constraint, but I also used the opportunity to improve the ergonomics of responding with errors in general. This PR includes changes to:
Error: std::error::Errorconstraint;SourceErrortype into aTargetErrortype, so the caller doesn't have to call.into();Review
Anyone can review this, but since this blocks #2801 and @teor2345 is already reviewing that PR, I tagged them directly.
Reviewer Checklist
Follow Up Work