Stop calculating transaction hashes twice in the checkpoint verifier #2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
|
macOS failed due to a bad set of peers: I pushed a change anyway, so let's see how CI goes. |
Merged
2 tasks
teor2345
force-pushed
the
checkpoint-verifier-efficient
branch
from
850b9ed to
52cef8c
Compare
jvff
previously approved these changes
Aug 30, 2021
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
teor2345
force-pushed
the
checkpoint-verifier-efficient
branch
from
14dde60 to
279b79f
Compare
|
Applied suggestions after approval, and admin-merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that we were accidentally calculating transaction hashes twice in the checkpoint verifier.
This could be really inefficient for large blocks and large transactions.
This is unexpected work in sprint 17.
Solution
FinalizedBlocks in the checkpoint verifierRequestBlocktype to simplify a complex method return typeReview
@jvff can review this PR.
It's not urgent at all.
This PR is based on PR #2695, so it might need a rebase after that PR merges.
Reviewer Checklist