Refactor BestTipHeight into a generic ChainTip sender and receiver #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fastmod BestTipHeight ChainTipSender zebra*` For senders: `fastmod best_tip_height chain_tip_sender zebra*` For receivers: `fastmod best_tip_height chain_tip_receiver zebra*`
And add convenience impls for optional and empty chain tips.
teor2345
added
A-rust
This was referenced Aug 26, 2021
This comment has been minimized.
This comment has been minimized.
jvff
previously approved these changes
Aug 26, 2021
I've updated the type names in that ticket, and added another impacted type. |
Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
|
I applied the approved updates, and we're a few PRs behind, so I admin-merged this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In ticket #2639, we want to get block hashes, transaction information, and rollback information out of the state.
The
BestTipHeightstruct already gets block heights out of the state. We can add this other information to it as well.Solution
BestTipHeighttoChainTipSenderbest_tip_heightmodule tochain_tipChainTipReceiverstructChainTiptrait to avoid tricky crate dependenciesChainTiptrait in zebra-networkThis refactor does not add any new information, or close any tickets.
Review
@jvff worked on this a few weeks ago.
The code might make more sense once you've had a look at PR #2677, which adds block hashes to the chain tip recevier.
Reviewer Checklist
Follow Up Work
Actually provide all the extra information.