-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use unmined types for transaction verifier mempool requests and responses #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
reviewed
Aug 25, 2021
dconnolly
reviewed
Aug 25, 2021
dconnolly
reviewed
Aug 25, 2021
dconnolly
reviewed
Aug 25, 2021
dconnolly
previously approved these changes
Aug 25, 2021
Co-authored-by: Deirdre Connolly <[email protected]>
a642d84
to
cc399c5
Compare
conradoplg
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've rebased and force-pushed after #2665 was merged, so I'll leave it for @teor2345 or @dconnolly to check if I did that correctly and merge this (and address @daira's comments if desired)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that
zebra-network
uses unmined types for transactions, we also need to use them in the transaction verifier'sMempool
request.Solution
UnminedTx
in transaction verifierMempool
requestsUnminedTxId
as the transaction verifier response typeWe'll want the full witnessed ID even for
Block
requests, because it will help us diagnose mined transaction verification failures, and auth data root verification failures.Minor cleanup:
is_mempool
into a transaction verifier request methodReview
@conradoplg might want this PR before starting work on #2637, so the types match up.
This PR is based on PR #2665, feel free to rebase it on
main
if needed.Reviewer Checklist
We'll add more tests for this code as part of the mempool work.