Split ValueBalance methods into NegativeAllowed and NonNegative #2649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some
ValueBalance
methods only make sense forNegativeAllowed
orNonNegative
.If we make them generic, it's harder to use them correctly.
And type inference can fail on the generic, which makes code harder to write.
Solution
ValueBalance<NonNegative>
andValueBalance<NegativeAllowed>
ValueBalance<NonNegative>
, like the finalized stateReview
@oxarbitrage can review this PR, it also includes some of the test methods from PR #2647 and oxarbitrage#130
Reviewer Checklist