Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to, not past, activation for regenerate-stateful-test-disks.yml #2601

Merged
merged 6 commits into from
Aug 11, 2021

Conversation

dconnolly
Copy link
Contributor

@dconnolly dconnolly commented Aug 11, 2021

Motivation

The regenerate-stateful-test-disks.yml workflow was syncing past, not to, the latest network upgrade.

Solution

s/sync_past/sync_to/g

Review

Follow Up Work


This change is Reviewable

@dconnolly dconnolly added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles labels Aug 11, 2021
@dconnolly dconnolly added this to the 2021 Sprint 16 milestone Aug 11, 2021
teor2345
teor2345 previously approved these changes Aug 11, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good, but I might get @conradoplg to double-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update regenerate-stateful-test-disks.yml to create images from the disks if they succeed
3 participants