Remove unreliable generated chain prevouts tests #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And adjust the chain lengths for better coverage.
teor2345
added
C-bug
conradoplg
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jvff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #2525 added some extra tests for generated chains, but they were unreliable.
(Strangely, these tests passed locally and in the PR, but failed fairly often on
main.)Solution
Review
This is blocking PR #2531, so @conradoplg might want to review this to unblock that PR.
@jvff reviewed PR #2525, so he might be able to review this one quickly.
Reviewer Checklist
This change is