Test consensus-critical Amount
deserialization
#2487
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra isn't testing consensus-critical serialization for
Amount
.Previously we were testing
serde
andbincode
serialization, which uses a completely different code path.This change is important to do now, because:
ValueBalance
using theAmount
tests as examplesSpecifications
And similar rules for transparent and Sprout.
https://zips.z.cash/protocol/protocol.pdf#txnconsensus
Solution
bincode
serialization tests withZcashDeserialize
testsbincode
test dependencyAmount
debug formatReview
@oxarbitrage can review this bug fix, it blocks the tests for PR #2486.
Reviewer Checklist