Further test new transaction consensus rules #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Jun 4, 2021
teor2345
reviewed
Jun 4, 2021
teor2345
reviewed
Jun 4, 2021
There was a problem hiding this comment.
Should the PR include some extra tests for the V4 rules applied to V5 transactions?
Should there be tests for V4 transactions?
What would be useful to have as a proptest? (Should some of these test vectors become proptests?)
This seems like enough tests for now - I'd rather focus on fixes to the network stack, and implementing more NU5 consensus rules.
Similar to the `vec!` macro, but doesn't allow creating an empty list.
Create a dummy transaction with no inputs and no outputs, and add a dummy Orchard action to it. The `check::has_inputs_and_outputs` should succeed, because the consensus rule considers having Orchard actions as having inputs and/or outputs.
Move the code to create a fake Orchard shielded data instance to a helper function in `zebra_chain::transaction::arbitrary`, so that other tests can also use it.
A V5 coinbase transaction that has Orchard shielded data MUST NOT have the enable spends flag set.
A coinbase transaction with Orchard shielded data and without the enable spends flag set should be valid.
Co-authored-by: teor <[email protected]>
jvff
force-pushed
the
further-test-new-transaction-consensus-rules
branch
from
6e87237 to
665c84e
Compare
14 tasks
teor2345
reviewed
Jun 7, 2021
teor2345
approved these changes
Jun 7, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some recent PRs (#2229 and #2236) added some new V5 transaction consensus rules. However, they weren't thoroughly tested.
Solution
This PR adds three new test vectors:
check::has_inputs_and_outputswith a transaction that has Orchard actionscheck::coinbase_tx_no_prevout_joinsplit_spendwith:enableSpendsOrchardflag setenableSpendsOrchardflag not setFor the implementation of these tests, a helper function was implemented (
insert_dummy_orchard_shielded_data) that changes a V5 transaction to include a dummy instance oforchard::ShieldedData. A mutable reference to the shielded data is returned in case the test wants to customize the data.The PR also includes an
at_least_one!helper macro, that is usable for tests.The code in this pull request has:
Open questions
Review
Anyone can review this low priority PR.
Related Issues
Part of #1980
Follow Up Work