Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action methods #2199

Merged
merged 2 commits into from
May 26, 2021
Merged

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We added some Action methods to shielded_data of orchard in #2185 however we might need them before that PR gets merged for #1980

Solution

Split that code in a separated PR.

Review

@teor2345 or @jvff

Related Issues

#1980
#1982
#1983

Copy link
Contributor

@jvff jvff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion to the documentation.

zebra-chain/src/orchard/shielded_data.rs Outdated Show resolved Hide resolved
teor2345
teor2345 previously approved these changes May 26, 2021
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since other work depends on this PR, I'm going to commit the suggestions and merge.

Co-authored-by: Janito Vaqueiro Ferreira Filho <[email protected]>
@teor2345 teor2345 enabled auto-merge (squash) May 26, 2021 01:39
@teor2345 teor2345 merged commit c3820b4 into ZcashFoundation:main May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants