Replace canopy.pdf instances left in our codebase #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on some confirmations for #1823 i found that we still have some links pointing to canopy.pdf.
After the NU for Canopy passed the content from the canopy.pdf was merged into protocol.pdf.
Solution
We should always point to protocol.pdf except when the sections we are referring to are not stable yet. When this happens we should do a routine cleanup like this PR to replace the links after the NU pass. For example now that we are working on NU5 i will expect links to orchard.pdf. This are fine for a while, then we need to change them.
This PR changes all the canopy.pdf instances we have left in our codebase(we changed a few before).
Review
Anyone can review, this is low priority.