Stop using /dev/shm on Linux #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems have a very small /dev/shm, for example, see: docker-library/postgres#416 So we should just use the temporary directory on all operating systems. Also: * use TempDir to generate the temporary path * delete the code that we copied from sled * prefix the temporary path with the state version and network
teor2345
added
C-bug
yaahc
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some systems have a very small
/dev/shm.For example, docker's default
/dev/shmsize is 64 MB: Hit by size limit of /dev/shm docker-library/postgres#416And
/dev/shmisn't really intended for applications to store arbitrary-sized temporary files. It's meant to be used as a file-based interface to shared memory for inter-process communication.We copied a bunch of complex code from sled, which we don't really need.
(We also didn't credit the author, which is required under the MIT and Apache licenses.)
To help users identify orphaned Zebra temporary directories, we should prefix them with "zebra", the state version, and the network.
Solution
The code in this pull request has:
Review
@yaahc wrote this code.
This review is not urgent.
This bug could cause errors on long-running ephemeral tests in docker containers with the default
/dev/shmsize. But we're not seeing those errors yet.Related Issues
This bug existed in sled, and we copied it across when we moved to RocksDB in #1325.