Skip to content

Commit

Permalink
Change skip network test name and comments
Browse files Browse the repository at this point in the history
  • Loading branch information
oxarbitrage authored and dconnolly committed Feb 15, 2021
1 parent 9056435 commit f85006a
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,11 @@ jobs:
- name: Install LLVM on Windows
if: matrix.os == 'windows-latest'
run: choco install llvm -y
- name: Skip network tests on Ubuntu and Windows
# Ubuntu runners don't have network or DNS configured during test steps
# Windows runners have an unreliable network
if: matrix.os == 'ubuntu-latest' || matrix.os == 'windows-latest'
- name: Run network tests only on macOS
# Only macOS runners have all network capabilities:
# https://docs.github.com/en/actions/reference/specifications-for-github-hosted-runners#cloud-hosts-for-github-hosted-runners
# Tests that only check launch behaviour or local port binding are not skipped in any platform.
if: matrix.os != 'macOS-latest'
run: echo "ZEBRA_SKIP_NETWORK_TESTS=1" >> $GITHUB_ENV
- name: Run tests
env:
Expand Down

0 comments on commit f85006a

Please sign in to comment.