add metrics endpoint port conflict hint

zebra-network/src/peer_set/initialize.rs

@@ -218,7 +218,7 @@ where
         Err(_) => panic!(
             "{} {} {}",
             "Listener failed. Port already in use.",
-            "Is another instance of zebrad or zcashd running in your local machine ?",
+            "Is another instance of zebrad or zcashd running in your local machine?",
             "Consider changing the default port in the configuration file."
         ),
     };

zebra-state/src/service/finalized_state.rs

@@ -47,7 +47,7 @@ impl FinalizedState {
             Ok(d) => d,
             Err(_) => panic!(
                 "{} {}",
-                "LOCK file in use.", "Check if there is antoher zebrad process running."
+                "LOCK file already in use.", "Check if there is antoher zebrad process running."
             ),
         };
 

zebrad/src/application.rs

@@ -164,8 +164,7 @@ impl Application for ZebradApp {
                         Some(as_string) => as_string,
                         None => return true,
                     };
-                    !error_str.contains("Port already in use")
-                        && !error_str.contains("LOCK file in use")
+                    !error_str.contains("already in use")
                 }
                 color_eyre::ErrorKind::Recoverable(error) => {
                     // type checks should be faster than string conversions

zebrad/src/components/metrics.rs

@@ -13,10 +13,18 @@ impl MetricsEndpoint {
     pub fn new(config: &ZebradConfig) -> Result<Self, FrameworkError> {
         if let Some(addr) = config.metrics.endpoint_addr {
             info!("Initializing metrics endpoint at {}", addr);
-            metrics_exporter_prometheus::PrometheusBuilder::new()
+            let check_endpoint = metrics_exporter_prometheus::PrometheusBuilder::new()
                 .listen_address(addr)
-                .install()
-                .expect("FIXME ERROR CONVERSION");
+                .install();
+            match check_endpoint {
+                Ok(endpoint) => endpoint,
+                Err(_) => panic!(
+                    "{} {} {}",
+                    "Port for metrics endpoint already in use by another process:",
+                    addr,
+                    "- You can change the metrics default endpoint in the config."
+                ),
+            }
         }
         Ok(Self {})
     }