Skip to content

Commit

Permalink
Disable RPC port conflict tests on Windows and macOS (#5072)
Browse files Browse the repository at this point in the history
  • Loading branch information
teor2345 authored Sep 5, 2022
1 parent ceff590 commit 524e9ab
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions zebra-rpc/src/server/tests/vectors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,12 @@ fn rpc_server_spawn_unallocated_port(parallel_cpu_threads: bool) {
}

/// Test if the RPC server will panic correctly when there is a port conflict.
///
/// This test is sometimes unreliable on Windows, and hangs on macOS.
/// We believe this is a CI infrastructure issue, not a platform-specific issue.
#[test]
#[should_panic(expected = "Unable to start RPC server")]
#[cfg(not(any(target_os = "windows", target_os = "macos")))]
fn rpc_server_spawn_port_conflict() {
let _init_guard = zebra_test::init();

Expand Down Expand Up @@ -234,7 +238,11 @@ fn rpc_server_spawn_port_conflict() {
///
/// If this test fails, that's great!
/// We can make parallel the default, and remove the warnings in the config docs.
///
/// This test is sometimes unreliable on Windows, and hangs on macOS.
/// We believe this is a CI infrastructure issue, not a platform-specific issue.
#[test]
#[cfg(not(any(target_os = "windows", target_os = "macos")))]
fn rpc_server_spawn_port_conflict_parallel_auto() {
let _init_guard = zebra_test::init();

Expand Down

0 comments on commit 524e9ab

Please sign in to comment.