Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support serializing SigningNonces #595

Merged
merged 1 commit into from
Jan 16, 2024
Merged

support serializing SigningNonces #595

merged 1 commit into from
Jan 16, 2024

Conversation

conradoplg
Copy link
Contributor

Closes #591

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a1350ea) 82.07% compared to head (b4d7d66) 82.09%.

Files Patch % Lines
frost-core/src/round1.rs 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   82.07%   82.09%   +0.01%     
==========================================
  Files          31       31              
  Lines        3152     3166      +14     
==========================================
+ Hits         2587     2599      +12     
- Misses        565      567       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Jan 16, 2024
@mergify mergify bot merged commit 9921b12 into main Jan 16, 2024
15 checks passed
@mergify mergify bot deleted the serialize-signing-nonces branch January 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public visibility of from_nonces for SigningNonces
2 participants