Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deserialization issue in ciphersuite_deserialize #589

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

mimoo
Copy link
Contributor

@mimoo mimoo commented Dec 1, 2023

fixes #588

@mpguerra mpguerra requested a review from conradoplg December 4, 2023 10:44
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (221c089) 82.06% compared to head (67b988f) 82.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files          31       31           
  Lines        3151     3151           
=======================================
  Hits         2586     2586           
  Misses        565      565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mergify mergify bot merged commit 6d82adf into ZcashFoundation:main Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug: invalid type: string \"FROST-secp256k1-SHA256-v1\", expected a borrowed string
2 participants