Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DKG vector tests #587

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Create DKG vector tests #587

merged 5 commits into from
Dec 4, 2023

Conversation

natalieesk
Copy link
Contributor

This closes #567

@natalieesk natalieesk linked an issue Nov 30, 2023 that may be closed by this pull request
Create DKG vector tests #567
Closed
conradoplg
conradoplg previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super useful, thank you!

There is just a lingering TODO, up to you if you want to do that now or later. I'll leave this approved so feel free to mark that comment as resolved or address it.

frost-core/src/tests/vectors_dkg.rs Outdated Show resolved Hide resolved
@conradoplg
Copy link
Contributor

Ah, there is also a merge conflict

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (221c089) 82.06% compared to head (1e72000) 82.07%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   82.06%   82.07%           
=======================================
  Files          31       31           
  Lines        3151     3152    +1     
=======================================
+ Hits         2586     2587    +1     
  Misses        565      565

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mergify bot added a commit that referenced this pull request Dec 4, 2023
@mergify
Merge of #587
1069191
@mergify mergify bot mentioned this pull request Dec 4, 2023
Closed
7 tasks
@mergify mergify bot merged commit 1e29230 into main Dec 4, 2023
15 checks passed
@mergify mergify bot deleted the dkg_testing_567 branch December 4, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradoplg conradoplg conradoplg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create DKG vector tests
2 participants
@natalieesk @conradoplg