Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frost-core: split part of lib.rs into traits.rs and serialization.rs #569

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

conradoplg
Copy link
Contributor

As mentioned in #568 , lib.rs got too big so I split parts of it into traits.rs and serialization.rs.

While doing that I noticed that some types were pub but they didn't need to be, so I hid them.

@conradoplg conradoplg requested a review from natalieesk October 31, 2023 18:26
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (71c0925) 81.94% compared to head (9145519) 81.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          30       31    +1     
  Lines        3151     3151           
=======================================
  Hits         2582     2582           
  Misses        569      569           
Files Coverage Δ
frost-core/src/error.rs 84.61% <ø> (ø)
frost-core/src/identifier.rs 98.64% <ø> (ø)
frost-core/src/keys.rs 97.75% <ø> (ø)
frost-core/src/keys/dkg.rs 87.64% <ø> (ø)
frost-core/src/keys/repairable.rs 97.18% <ø> (ø)
frost-core/src/round1.rs 92.65% <ø> (ø)
frost-core/src/round2.rs 100.00% <ø> (ø)
frost-core/src/verifying_key.rs 98.52% <100.00%> (ø)
frost-ed25519/src/lib.rs 65.92% <ø> (ø)
frost-ed448/src/lib.rs 65.92% <ø> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot merged commit 408540f into main Nov 7, 2023
3 checks passed
@mergify mergify bot deleted the split-librs branch November 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants