Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: misc cleanups #407

Merged
merged 1 commit into from
Dec 26, 2024
Merged

server: misc cleanups #407

merged 1 commit into from
Dec 26, 2024

Conversation

conradoplg
Copy link
Contributor

Based on #307

This improves some stuff I noticed while working on ZcashFoundation/frost#811

  • Change default port of clients to 443 (this will mismatch with the server default 2744 on purpose; the user is supposed to deploy nginx on 443 and redirect to 2744, or do their own thing by specifying the ports using the flags)
  • Use PublicKey for other instances of public key in arguments, to make sure they're serialized as hex strings and not as arrays of numbers
  • Remove num_signers from session handling, it's not really needed
  • Make the server logs in INFO level by default (before it wouldn't log anything unless RUST_LOG variable was set)
  • Change tracing logs to DEBUG instead of INFO
  • Renamed uuid argument to challenge

@mpguerra mpguerra requested a review from natalieesk December 16, 2024 08:55
@conradoplg conradoplg force-pushed the https-support branch 2 times, most recently from af30b6f to c37e2df Compare December 26, 2024 19:44
Base automatically changed from https-support to main December 26, 2024 19:44
@conradoplg
Copy link
Contributor Author

I'm admin-merging this to get things going. We can do an overall review/testing pass when we finish the current scope.

@conradoplg conradoplg merged commit d7b6ab7 into main Dec 26, 2024
5 checks passed
@conradoplg conradoplg deleted the misc-cleanups branch December 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant