Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MetaBrainz.Common to version 4.0.0 #50

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Bump MetaBrainz.Common to version 4.0.0 #50

merged 1 commit into from
Jan 4, 2025

Conversation

Zastai
Copy link
Owner

@Zastai Zastai commented Jan 4, 2025

This drops all non-async versions of async methods (i.e. JsonUtils.Deserialize<T>() and JsonUtils.GetJsonContent<T>()).

Note that the version of JsonUtils.Deserialize<T>() taking a string remains; it has no async version.

@Zastai
Bump MetaBrainz.Common to version 4.0.0
7421b3d 
This also drops all non-`async` versions of `async` methods (i.e.
`JsonUtils.Deserialize<T>()` and `JsonUtils.GetJsonContent<T>()`).

Note that the version of `JsonUtils.Deserialize<T>()` taking a `string`
remains; it has no `async` version.
@Zastai Zastai added dependencies Updates to dependencies breaking An incompatible change to a feature or API (requires a bump of the major version) nuget Version updates for NuGet packages labels Jan 4, 2025
@Zastai Zastai self-assigned this Jan 4, 2025
@Zastai Zastai merged commit ca8a7e4 into main Jan 4, 2025
2 checks passed
@Zastai Zastai deleted the update-common branch January 4, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Zastai Zastai

Labels
breaking An incompatible change to a feature or API (requires a bump of the major version) dependencies Updates to dependencies nuget Version updates for NuGet packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Zastai