Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/z uploader and z textarea #502

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

OleksandrOleksyuk
Copy link
Collaborator

@OleksandrOleksyuk OleksandrOleksyuk commented Jan 13, 2025

Bugfix/z uploader and z textarea

Motivation and Context

With the latest ds releases

  • the file upload has a fixed size, on drag&drop.
  • z-input type text-area on the other hand if you put a background around the element, it is also put at the internal padding of the textarea

Priority

  • 1 - Highest
  • 2 - High
  • 3 - Medium
  • 4 - Low
  • 5 - Lowest
  • 6 - Not a Priority

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Component (add a Component as approved by Design System)
  • Docs (add documentation)
  • Chore (changes that adds small enhancement)
  • Breaking (fix or feature that would cause existing functionality to not work as expected)

Design

Screenshots

image-20250113-090521 image-20250113-090445

Note

@OleksandrOleksyuk OleksandrOleksyuk requested review from DarioSacco and removed request for PaoloFrancesco-Marino January 13, 2025 09:48
@OleksandrOleksyuk
Copy link
Collaborator Author

Ciao @DarioSacco , alla fine abbiamo tolto la width: 772px;.

Ti spiego brevemente il motivo di questa scelta.
Sia myZanichelli, laZ Esercizi e laZ Mappe necessitano che il file uploader si adatti al container, e non che abbia una width fissa di 772px.

image
image
image

La avevi impostata per un motivo specifico?

@DarioSacco
Copy link
Collaborator

Ciao @DarioSacco , alla fine abbiamo tolto la width: 772px;.

Ti spiego brevemente il motivo di questa scelta. Sia myZanichelli, laZ Esercizi e laZ Mappe necessitano che il file uploader si adatti al container, e non che abbia una width fissa di 772px.

image image image

La avevi impostata per un motivo specifico?

Ciao, sì era solo per mantenere le proporzioni usate nel design visto che non era specificato dovesse prendere tutta la larghezza ma se i casi d'uso sono principalmente quelli, direi che va bene così.

@OleksandrOleksyuk OleksandrOleksyuk merged commit 227cc05 into master Jan 13, 2025
3 checks passed
@OleksandrOleksyuk OleksandrOleksyuk deleted the bugfix/z-uploader-and-z-textarea branch January 13, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants