Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-add domain to domain list everytime user use just-read on webpage #166

Closed
wants to merge 1 commit into from

Conversation

honeybar
Copy link

Hello, this is my first time contributing to open source project. I made changes to content_script.js such that now, every time user use just-read on the webpage, it will check if the domain exists in auto-enable-site-list, and if it doesn't, it will add it automatically, so everytime user visit any page in the domain, Just-read will automatically be pulled up.

@ZachSaucier
Copy link
Owner

ZachSaucier commented Jul 12, 2018

Thanks for the contribution! I'll include this feature in the next update.

A few notes:

  • I won't be merging this directly because this functionality will need to be enabled/disabled through a checkbox on the Options (-> "Additional options") page.
  • I also will modify your approach a little bit to follow the approach mention in the related issue, 'Add this domain to your auto run list' button/hotkey #152, where it will add the plain domain (example.com if Just Read is started on the top level, and add example.com/.+ if it isn't the top level in order to keep the functionality consistent. I've actually already implemented the code for 'Add this domain to your auto run list' button/hotkey #152, I just haven't gotten to merge it into the master yet.
  • When contributing to projects like this, you should match the programming style already being used. For you that means adding semicolons and a little bit of white space changes. Don't worry about changing it now because I'll need to make the above changes as well 😄

Thanks again for contributing! I hope it's the first of many of your contributions.

@ZachSaucier
Copy link
Owner

ZachSaucier commented Jul 16, 2018

This functionality is added in JR version 1.1.13 (3908ad7). Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants