Skip to content

Commit

Permalink
Update dependency com.slack.lint.compose:compose-lint-checks to v1.4.1 (
Browse files Browse the repository at this point in the history
  • Loading branch information
renovate[bot] authored Oct 3, 2024
1 parent 8b1cdba commit 0ea65db
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 73 deletions.
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[versions]
accompanist = "0.36.0"
agp = "8.7.0-beta02"
agp = "8.7.0"
androidx-activity = "1.10.0-alpha02"
androidx-core = "1.15.0-beta01"
androidx-sqlite = "2.5.0-alpha09"
Expand Down Expand Up @@ -214,7 +214,7 @@ kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotl
kotlinx-immutable = "org.jetbrains.kotlinx:kotlinx-collections-immutable:0.3.8"
kotlinx-serialization-core = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core", version.ref = "kotlinx-serialization" }

lints-compose = "com.slack.lint.compose:compose-lint-checks:1.3.1"
lints-compose = "com.slack.lint.compose:compose-lint-checks:1.4.1"

markdown = { module = "com.mikepenz:multiplatform-markdown-renderer-m3", version.ref = "markdown" }

Expand Down
26 changes: 0 additions & 26 deletions libraries/base-ui/lint-baseline.xml

This file was deleted.

46 changes: 1 addition & 45 deletions libraries/compose-extensions/lint-baseline.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.4.0-alpha06" type="baseline" client="gradle" dependencies="false" name="AGP (8.4.0-alpha06)" variant="all" version="8.4.0-alpha06">
<issues format="6" by="lint 8.7.0" type="baseline" client="gradle" dependencies="false" name="AGP (8.7.0)" variant="all" version="8.7.0">

<issue
id="ComposeModifierComposed"
Expand All @@ -12,48 +12,4 @@
column="3"/>
</issue>

<issue
id="ComposeCompositionLocalUsage"
message="`CompositionLocal`s are implicit dependencies and creating new ones should be avoided. See https://slackhq.github.io/compose-lints/rules/#compositionlocals for more information."
errorLine1="val LocalEnabled = compositionLocalOf { true }"
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/catchup/compose/DisableableContent.kt"
line="8"
column="1"/>
</issue>

<issue
id="ComposeCompositionLocalUsage"
message="`CompositionLocal`s are implicit dependencies and creating new ones should be avoided. See https://slackhq.github.io/compose-lints/rules/#compositionlocals for more information."
errorLine1="val LocalDisplayFeatures = staticCompositionLocalOf&lt;List&lt;DisplayFeature>> { emptyList() }"
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/catchup/compose/DisplayFeatures.kt"
line="6"
column="1"/>
</issue>

<issue
id="ComposeCompositionLocalUsage"
message="`CompositionLocal`s are implicit dependencies and creating new ones should be avoided. See https://slackhq.github.io/compose-lints/rules/#compositionlocals for more information."
errorLine1="val LocalDynamicTheme = compositionLocalOf { false }"
errorLine2="~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/kotlin/catchup/compose/DynamicTheme.kt"
line="9"
column="1"/>
</issue>

<issue
id="ComposeCompositionLocalUsage"
message="`CompositionLocal`s are implicit dependencies and creating new ones should be avoided. See https://slackhq.github.io/compose-lints/rules/#compositionlocals for more information."
errorLine1="/**"
errorLine2="^">
<location
file="src/main/kotlin/catchup/compose/ScrollToTop.kt"
line="32"
column="1"/>
</issue>

</issues>
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ fun columnCount(minColumns: Int, minColumnWidth: Dp = 250.dp): Int {
return (availableWidth / minWidthPx).toInt().coerceAtLeast(minColumns)
}

@Suppress("ComposeContentEmitterReturningValues")
@Composable
fun rememberAvailableWidth(): Float {
var availableWidth by remember { mutableFloatStateOf(0f) }
Expand Down

0 comments on commit 0ea65db

Please sign in to comment.