-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(arduino): Arduino IDE build failure #94
Conversation
…ties` Suspected cause of the Arduino IDE build failure.
…ties` Suspected cause of the Arduino IDE build failure.
…CRSFforArduino into broken-arduino-ide-build
Finally! My workflow automations are working. =^/.^= |
This is very strange. 🤔
...and everything passed with flying colours. I don't know why the Arduino CI build is failing here. This may need further investigation. Now, the Arduino CI failure is actually outside the scope of this Pull Request. I have concluded this Pull Request, and I will merge it into the maintenance branch. Then, make a cut of Version 1.0.1 off of it, tomorrow. |
This is still being problematic! Therefore, I am disabling it for the time being, until I allocate some time later on down the track to fix this up.
Relative links broke the badges
Let's see whether-or-not they will display their respective statuses now.
I `MAY` need to temporarily re-enable the `arduinoide_build.yml` file in order for this to do its thing.
This should make things look a little more presentable
… Releases and Licence badges
Right-oh. This is practically ready-to-go. Once the build passes, I will merge this Pull Request into the Version 1.0.x Maintenance Branch. |
Overview
This Pull Request fixes #93
The Arduino CI workflow is still having problems. However, the extent of these issues are outside the scope of this Pull Request.
The goal of this Pull Request was to fix some typos in the
library.properties
file, and I have achieved precisely that.As for the Arduino CI itself, I will keep it disabled for the time being, until I get around to figuring out what the f*** is going on with it. Already, it was bogging me down and I was going down a rabbit hole that lead nowhere.
Details
Some typos in
library.properties
were found to be the culprit of builds failing in the Arduino IDE.This Pull Request resolves that. Plus, disables the Arduino CI for the time being.
Additional
All of the badges in the
README.md
have been re-arranged, with the Build Status flags for both the Arduino IDE and PlatformIO have been re-factored. The Arduino IDE and PlatformIO Build Status badges are fully functional, and indicate whether-or-not their respective CI build check passes.Currently, I am still having issues with the Arduino CI side of things.
However, as I have repeatedly stated, CRSF for Arduino builds in Arduino IDE v2.3.2 with impunity, despite the Build Status badge saying otherwise.