Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(quality control): Use an isolated version of CFA_Config.hpp for Defect Detector environment. #117

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

ZZ-Cat
Copy link
Owner

@ZZ-Cat ZZ-Cat commented Apr 19, 2024

Overview

This is a quick follow-up to 5b5a898.
Instead of the Defect Detector using CFA_Config.hpp, the defines in the configuration are declared in the build_flags section of the Defect Detector's environment.

Benefits

Any configurations made to CFA_Config.hpp no longer affects the outcome of my overall Quality Control.
This frees CFA_Config.hpp to be set to whichever way I want/need it to be to provide the best quality default configuration that most people will use.

It also means that I can run various combinations of configurations through my Defect Detector without affecting CFA_Config.hpp. Say, if I wanted to disable CRSF_RC_ENABLED but I wanted to leave CRSF_TELEMETRY_ENABLED turned on, I can do that without touching CFA_Config.hpp.

In other words...

This is mostly a quality-of-life thing from a developer's point-of-view.
The more modular CRSF for Arduino is, the easier it is to test key aspects in isolation, and (by extension) that means improving the overall quality of the code-base.

…pp` for Defect Detector's environment.

This configures CRSF for Arduino with everything enabled, to ensure all defects (if any) are picked up by the Defect Detector.
…is not assigned a value in 'SerialReceiver::operator='.
@ZZ-Cat ZZ-Cat added the CI/CD 🚧 Continuous Integration/Continuous Deployment label Apr 19, 2024
@ZZ-Cat ZZ-Cat self-assigned this Apr 19, 2024
@ZZ-Cat ZZ-Cat added this to the Version 1.1.0 milestone Apr 19, 2024
@ZZ-Cat ZZ-Cat mentioned this pull request Apr 19, 2024
29 tasks
@ZZ-Cat ZZ-Cat merged commit 406c8b6 into Main-Trunk Apr 19, 2024
3 checks passed
@ZZ-Cat ZZ-Cat deleted the refactor_quality_control branch April 19, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🚧 Continuous Integration/Continuous Deployment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant