Add ts-ignore to dynamic require #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unzipper is designed to be a small library and therefore does not include by default various clients for external integrations, such as the request library and the aws sdk. In most methods the "client" has to be passed into the respective function as an argument, but with aws_v3 we need multiple functions from the library, so it is "required" dynamically, but only when you call the aws_s3 function directly. (which means you have to separately
The dynamic require however seems to cause problems with type checking with some combination of
tscandts-loaderat the compilation stage (this is not a runtime error).